[Skiboot] [RFC PATCH 1/2] config: introduce CONFIG_FSP in Makefiles

Patrick Williams patrick at stwcx.xyz
Wed Jul 13 02:04:10 AEST 2016

On Tue, Jul 12, 2016 at 09:19:21AM -0500, Elizabeth Liner wrote:
> Hey Stewart,
> I was able to work on the XZ changes and recently got it merged and
> reviewed:
> 	Hostboot p8 review:
> https://ralgit01.raleigh.ibm.com/gerrit1/#/c/24609/
> 	Op-build pull request:
> https://github.com/open-power/op-build/pull/520
> 	Open-power/pnor pull request:
> https://github.com/open-power/pnor/pull/48
> So now, you should be able to compress and decompress a section without
> additional pnor changes with op-build/master-next.  However we currently
> are not automatically processing if a section is compressed or not, so if
> you need hostboot to decompress the image, I'll have to add in some
> additional functionality.  The skiboot image will be processed though.  Let
> me know if you have any trouble with the compression/decompression or if
> you want to add in another section.

Since we no longer need PNOR flags to enable this, I wonder if we should
enable this by default for the skiboot partition.  Any opinions on this?

> Also, here's the compression command that works with the xz decompressor:
> xz --check=crc32 $image
> Best,
> Elizabeth
> --
> Elizabeth Liner
> Power Firmware Development - Hostboot
> IBM Systems & Technology Group - Austin, TX
> eliner at us.ibm.com
> 512-286-6493
> From:	Stewart Smith <stewart at linux.vnet.ibm.com>
> To:	Elizabeth Liner/Austin/IBM at IBMUS
> Cc:	C├ędric Le Goater <clg at fr.ibm.com>, skiboot at lists.ozlabs.org
> Date:	05/10/2016 08:55 PM
> Subject:	Re: [RFC PATCH 1/2] config: introduce CONFIG_FSP in Makefiles
> Elizabeth Liner <eliner at us.ibm.com> writes:
> > I'm hoping to get to the changes some time this month, but I'm not sure
> if
> > I have the time at this moment.
> > However, I can try to make this a priority if you think it would be
> useful
> > for the skiboot team.
> It would be useful - even in just a testing capacity, as I'd like to
> start doing test runs with a GCOV enabled skiboot so that we can get
> code coverage data out of op-test-framework. However, building with GCOV
> bloats the binary size to ~1.5MB - which isn't a problem on an FSP
> machine, but is for OpenPOWER where we only have the 1MB partition. But
> the xz compression will make this work.
> Plus, we're getting close to the 1MB size anyway, and I'd prefer to just
> compress it on flash (as this also speeds up boot time) than start
> having config options to not build everything into skiboot (as this
> enables developers/ODMs to get things horribly wrong).
> --
> Stewart Smith
> OPAL Architect, IBM.

> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot

Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20160712/8a4d8808/attachment.sig>

More information about the Skiboot mailing list