[Skiboot] [PATCH v2] hw/xscom: Reset XSCOM engine after querying sleeping core FIR

Vipin K Parashar vipin at linux.vnet.ibm.com
Tue Jul 12 06:34:33 AEST 2016


XSCOM engine blocks subsequently after querying FIR of any
sleeping core. This causes subsequent XSCOM opertions to hang
forever due to XSCOM engine being continuously busy. Reset XSCOM
engine after querying FIR of any sleeping core.

Signed-off-by: Vipin K Parashar <vipin at linux.vnet.ibm.com>
Signed-off-by: Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com>
---
Changes in v2:
 - Rebased against master

 hw/xscom.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/xscom.c b/hw/xscom.c
index e351672..0c00048 100644
--- a/hw/xscom.c
+++ b/hw/xscom.c
@@ -169,7 +169,8 @@ static int64_t xscom_handle_error(uint64_t hmer, uint32_t gcid, uint32_t pcb_add
 				gcid, pcb_addr, stat);
 		return OPAL_BUSY;
 
-	case 2: /* CPU is asleep, don't retry */
+	case 2: /* CPU is asleep, reset XSCOM engine and return */
+		xscom_reset(gcid);
 		return OPAL_WRONG_STATE;
 	case 3: /* Partial good */
 	case 4: /* Invalid address / address error */
-- 
2.7.4



More information about the Skiboot mailing list