[Skiboot] [PATCH 5/5] fsp-leds: add () around macros
Stewart Smith
stewart at linux.vnet.ibm.com
Fri Jul 8 10:38:35 AEST 2016
found by Smatch static analysis (http://smatch.sourceforge.net/):
hw/fsp/fsp-leds.c:576 fsp_msg_set_led_state() warn: the 'FSP_LED_EXCL_FAULT' ma\
cro might need parens
hw/fsp/fsp-leds.c:583 fsp_msg_set_led_state() warn: the 'FSP_LED_EXCL_IDENTIFY'\
macro might need parens
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
include/fsp-leds.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/fsp-leds.h b/include/fsp-leds.h
index 577e719b7703..c5a33ac6fc66 100644
--- a/include/fsp-leds.h
+++ b/include/fsp-leds.h
@@ -37,8 +37,8 @@
#define FSP_RSRC_PRSNC_UNKNOWN 0x80 /* Resource presence unknown */
/* LED exclusive bits */
-#define FSP_LED_EXCL_FAULT 1UL << 0
-#define FSP_LED_EXCL_IDENTIFY 1UL << 1
+#define FSP_LED_EXCL_FAULT (1UL << 0)
+#define FSP_LED_EXCL_IDENTIFY (1UL << 1)
/* LED update message source */
enum spcn_cmd_src {
--
2.1.4
More information about the Skiboot
mailing list