[Skiboot] [PATCH 4/5] phb3: fix inconsistent indenting

Stewart Smith stewart at linux.vnet.ibm.com
Fri Jul 8 10:38:34 AEST 2016


Found by smatch static analysis (http://smatch.sourceforge.net/):
hw/phb3.c:2331 capp_load_ucode() warn: inconsistent indenting
hw/phb3.c:3444 phb3_set_capi_mode() warn: inconsistent indenting

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hw/phb3.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/phb3.c b/hw/phb3.c
index 905fdf460423..d00f52956377 100644
--- a/hw/phb3.c
+++ b/hw/phb3.c
@@ -2328,7 +2328,7 @@ static int64_t capp_load_ucode(struct phb3 *p)
 	if ((be64_to_cpu(ucode->eyecatcher) != 0x43415050554C4944) ||
 	    (ucode->version != 1)) {
 		PHBERR(p, "CAPP: ucode header invalid\n");
-		    return OPAL_HARDWARE;
+		return OPAL_HARDWARE;
 	}
 
 	reg_offset = PHB3_CAPP_REG_OFFSET(p);
@@ -3441,7 +3441,7 @@ static int64_t phb3_set_capi_mode(struct phb *phb, uint64_t mode,
 			PHBERR(p,
 			       "CAPP: port already in use by another PHB:%x\n",
 			       chip->capp_phb3_attached_mask);
-			       unlock(&capi_lock);
+			unlock(&capi_lock);
 			return false;
 		}
 		chip->capp_phb3_attached_mask = 1 << p->index;
-- 
2.1.4



More information about the Skiboot mailing list