[Skiboot] [PATCH 22/28] lpc: Add P9 LPC interrupts support

[Michael Neuling]

On Thu, 2016-07-07 at 11:50 +1000, Benjamin Herrenschmidt wrote:
> We currently don't exploit the new MUX that allow to spread them
> around different PSI interrupts, they all go to LPC#0
> 
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

This bit breaks the build

-       // XXX TODO
-       //lpc_init_interrupts(chip);
+       printf("LPC: Bus on chip %d, access via MMIO @%p\n",
 }
 

with:

	[CC]  hw/lpc.o
hw/lpc.c: In function ‘lpc_init_chip_p9’:
hw/lpc.c:999:0: error: unterminated argument list invoking macro "printf"
 }
 ^
hw/lpc.c:929:2: error: ‘printf’ undeclared (first use in this function)
  printf("LPC: Bus on chip %d, access via MMIO @%p\n",
  ^
hw/lpc.c:929:2: note: each undeclared identifier is reported only once for each function it appears in
hw/lpc.c:929:2: error: expected ‘;’ at end of input
hw/lpc.c:929:2: error: expected declaration or statement at end of input
hw/lpc.c: At top level:
hw/lpc.c:459:16: error: ‘opal_lpc_write’ defined but not used [-Werror=unused-function]
 static int64_t opal_lpc_write(uint32_t chip_id, enum OpalLPCAddressType addr_type,
                ^
hw/lpc.c:518:16: error: ‘opal_lpc_read’ defined but not used [-Werror=unused-function]
 static int64_t opal_lpc_read(uint32_t chip_id, enum OpalLPCAddressType addr_type,
                ^
hw/lpc.c:865:13: error: ‘lpc_init_chip_p8’ defined but not used [-Werror=unused-function]
 static void lpc_init_chip_p8(struct dt_node *xn)
             ^
hw/lpc.c:893:13: error: ‘lpc_init_chip_p9’ defined but not used [-Werror=unused-function]
 static void lpc_init_chip_p9(struct dt_node *opb_node)
             ^
cc1: all warnings being treated as errorseaks the build with

	[CC]  hw/lpc.o
hw/lpc.c: In function ‘lpc_init_chip_p9’:
hw/lpc.c:999:0: error: unterminated argument list invoking macro "printf"
 }
 ^
hw/lpc.c:929:2: error: ‘printf’ undeclared (first use in this function)
  printf("LPC: Bus on chip %d, access via MMIO @%p\n",
  ^
hw/lpc.c:929:2: note: each undeclared identifier is reported only once for each function it appears in
hw/lpc.c:929:2: error: expected ‘;’ at end of input
hw/lpc.c:929:2: error: expected declaration or statement at end of input
hw/lpc.c: At top level:
hw/lpc.c:459:16: error: ‘opal_lpc_write’ defined but not used [-Werror=unused-function]
 static int64_t opal_lpc_write(uint32_t chip_id, enum OpalLPCAddressType addr_type,
                ^
hw/lpc.c:518:16: error: ‘opal_lpc_read’ defined but not used [-Werror=unused-function]
 static int64_t opal_lpc_read(uint32_t chip_id, enum OpalLPCAddressType addr_type,
                ^
hw/lpc.c:865:13: error: ‘lpc_init_chip_p8’ defined but not used [-Werror=unused-function]
 static void lpc_init_chip_p8(struct dt_node *xn)
             ^
hw/lpc.c:893:13: error: ‘lpc_init_chip_p9’ defined but not used [-Werror=unused-function]
 static void lpc_init_chip_p9(struct dt_node *opb_node)
             ^
cc1: all warnings being treated as errors
/home/mikey/src/skiboot-phb4/Makefile.rules:52: recipe for target 'hw/lpc.o' failed
make: *** [hw/lpc.o] Error 1
/home/mikey/src/skiboot-phb4/Makefile.rules:52: recipe for target 'hw/lpc.o' failed
make: *** [hw/lpc.o] Error 1