[Skiboot] [PATCH 07/28] lpc: Add basic P9 LPC read/write ops

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Jul 7 17:05:49 AEST 2016


On Thu, 2016-07-07 at 16:13 +1000, Michael Neuling wrote:
> Acked-by: Michael Neuling <mikey at neuling.org>
> 
> It might be nicer to have a ops structure for opb_read/write rather
> than
> doing this sort of thing at the start
> 
>        if (chip->lpc_mbase)
>                return opb_mmio_write(chip, addr, data, sz);
> 
> but that can come as a later cleanup.

Yeah maybe, the above is faster though and I don't think we'll
ever have *more* ops... it's basically old crap vs. proper MMIO.

Cheers,
Ben.



More information about the Skiboot mailing list