[Skiboot] [PATCH 09/28] interrupts: Remove #interrupt-cells from ICP nodes
Michael Neuling
mikey at neuling.org
Thu Jul 7 16:17:23 AEST 2016
On Thu, 2016-07-07 at 11:50 +1000, Benjamin Herrenschmidt wrote:
> It's not necessary and not in PAPR. HostBoot should probably do a
> similar change.
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
This breaks make check, but it's fixed again in two patches (11/28). We
should probably just merge these two patches.
Acked-by: Michael Neuling <mikey at neuling.org>
> ---
> hdata/paca.c | 1 -
> hdata/pcia.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hdata/paca.c b/hdata/paca.c
> index 6d001fd..7284a6e 100644
> --- a/hdata/paca.c
> +++ b/hdata/paca.c
> @@ -190,7 +190,6 @@ static void add_icps(void)
> irange, sizeof(irange));
> dt_add_property(icp, "interrupt-controller", NULL, 0);
> dt_add_property_cells(icp, "#address-cells", 0);
> - dt_add_property_cells(icp, "#interrupt-cells", 1);
> dt_add_property_string(icp, "device_type",
> "PowerPC-External-Interrupt-Presentation");
> for (i = 0; i < num_threads*2; i += 2) {
> diff --git a/hdata/pcia.c b/hdata/pcia.c
> index 8d11437..a54d4cf 100644
> --- a/hdata/pcia.c
> +++ b/hdata/pcia.c
> @@ -93,7 +93,6 @@ static void add_icp(const void *pcia, u32 tcount, const char *compat)
> dt_add_property(icp, "interrupt-controller", NULL, 0);
> dt_add_property(icp, "reg", reg, rsize);
> dt_add_property_cells(icp, "#address-cells", 0);
> - dt_add_property_cells(icp, "#interrupt-cells", 1);
> dt_add_property_string(icp, "device_type",
> "PowerPC-External-Interrupt-Presentation");
> free(reg);
More information about the Skiboot
mailing list