[Skiboot] [PATCH] PHB3: Disable UTL outbound discard error interrupt

Gavin Shan gwshan at linux.vnet.ibm.com
Wed Jul 6 10:09:45 AEST 2016


On Tue, Jul 05, 2016 at 06:36:26PM +1000, Stewart Smith wrote:
>Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
>
>> The UTL outbound discard error (bit#12) in UTL_PCIE_PORT_IRQ_EN
>> (offset: 0x558) isn't set in initial setup. It's set wrongly after
>> a reset on root port. With this bit set, frozen (all) error was
>> observed on the PHB to which a LPFC adapter is connected directly.
>>
>> This removes the bit in reset handler to avoid the unexpected
>> frozen (all) error.
>>
>>  BZ: 142877
>>
>> Reported-by: Pridhiviraj Paidipeddi <ppaidipe at in.ibm.com>
>> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>> ---
>> Good candidate for stable releases
>> ---
>>  hw/phb3.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>Merged to master as of ae0339e, but it doesn't apply cleanly to stable,
>able to send a patch for 5.2.x?
>

We needn't backport it to 5.2.x actually. The PCI hotplug patchset were
there before commit 2bb9c4bb2 ("PHB3: Fix unexpected ER (all) on errinjct
by PCI config") got merged. So the hotplug commit e1922cb ("hw/phb3: Support
PHB slot") kills the change introduced by 2bb9c4bb2 in master branch only.

Commit 2bb9c4bb2 were in 5.2.x and everything looks good there.

Thanks,
Gavin



More information about the Skiboot mailing list