[Skiboot] [PATCH 2/3] flash: Use blocklevel to do ECC reads

Stewart Smith stewart at linux.vnet.ibm.com
Tue Jul 5 19:01:42 AEST 2016

Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:

> On Tue, 2016-07-05 at 15:25 +1000, Alistair Popple wrote:
>> However in the ECC case blocklevel_read() mallocs an entire buffer for the 
>> ECC'd data rather than copying ECC data to the non-ECC buffer blocks at a time 
>> like flash_read_corrected(), so it may increase memory usage. In practice it 
>> won't change much though as we don't actually have any large ECC protected 
>> partitions at present.
> I'm very worried of malloc's at runtime though... we might want to look
> into fixing that.

flash_read_corrected also does the malloc in the case of ECC, so it's
not regression on runtime allocations at least (although it'd be good if
we could fix it)

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list