[Skiboot] Patch to support additional Barreleye nor flash chips
Andrew Donnellan
andrew.donnellan at au1.ibm.com
Mon Jan 18 15:17:38 AEDT 2016
Hi Adriana
On 14/01/16 06:18, Adriana Kobylak wrote:
> { 0xc22019, 0x02000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix
MXxxL25635F"},
> { 0xc2201a, 0x04000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix
MXxxL51235F"},
> { 0xef4018, 0x01000000, FL_ERASE_ALL, "Winbond
W25Q128BV" },
> + { 0xef4019, 0x02000000, FL_ERASE_ALL | FL_ERASE_64K | FL_CAN_4B |
> + FL_ERASE_BULK,
> + "Winbond
W25Q256BV"},
The general coding style in skiboot is to use tabs, rather than spaces
for indentation (similar to the Linux kernel) - could you resubmit your
patch using tabs set to 8 spaces?
Also, it's good practice to use the git send-email tool to send patches,
or to import the .patch file into your mail client as an entire email
message (alas, neither of these options are particularly easy if you're
using Notes-based email...). This helps us in reviewing patches, so if
you're planning on submitting patches regularly in future it'll be worth
setting all that up.
I don't have any other comments about the patch since I'm not familiar
with that part of the code :)
Andrew
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan at au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
More information about the Skiboot
mailing list