[Skiboot] [PATCH] p8-i2c: Send stop bit on timeouts

Stewart Smith stewart at linux.vnet.ibm.com
Fri Jan 15 15:04:35 AEDT 2016


Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> Some devices can leave the bus in a held state if we timeout
> in the middle of a request without sending a STOP.
>
> This happens for example with some TPM chips (we timeout for
> different reasons, our timeout is a bit too short for those chips,
> but this shall be fixed separately).
>
> This patch fixes it by always sending a STOP on  timeout.
>
> We also tidy things up a bit by using the same path as normal
> errors using a pseudo-error status bit.
>
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>  hw/p8-i2c.c | 32 +++++++++++++++++++-------------
>  1 file changed, 19 insertions(+), 13 deletions(-)

Applying: p8-i2c: Send stop bit on timeouts
fatal: corrupt patch at line 10
Patch failed at 0001 p8-i2c: Send stop bit on timeouts
The copy of the patch that failed is found in:
   /home/stewart/skiboot/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Looks like Evolution decided to base64 encode and do all sorts of awful
things.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list