[Skiboot] [PATCH 2/5] nvlink: Clear error registers at the end of the reset procedure
Alistair Popple
alistair at popple.id.au
Thu Jan 14 13:58:19 AEDT 2016
Hey,
On Thu, 7 Jan 2016 14:36:29 Russell Currey wrote:
<snip>
> +
> + /* Reset error registers. TODO: are there more we should clear here?
*/
> + npu_ioda_sel(npu_dev->npu, NPU_IODA_TBL_PESTB, 0, true);
> + for (val = 0; val < npu_dev->npu->total_devices; val++)
The PESTB is indexed by PE number right? So there could be more devices than
PESTB entries in the system if some devices are sharing PE#s (which the latest
kernel patches do) so we should be looping up to NPU_NUM_OF_PES rather than
npu->total_devices.
- Alistair
> + out_be64(npu_dev->npu->at_regs + NPU_IODA_DATA0, 0);
> +
> return PROCEDURE_COMPLETE;
> }
> DEFINE_PROCEDURE(reset_npu_dl);
>
More information about the Skiboot
mailing list