[Skiboot] [PATCH] SEL: Fix eSEL ID while logging eSEL event

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Jan 7 16:48:48 AEDT 2016


On 01/06/2016 10:46 AM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> Commit 127a7dac added eSEL ID to SEL event in reverse order (0700 instead
>> of 0007). This code fixes this issue by adding ID in proper order.
> 
> This was back in skiboot-5.1.0-beta2 - which means we've shipped systems
> producing these types of SEL events, so I don't think we can safely
> change that now - we may well be stuck with it.

Stewart,

This is a bug I introduced in the first place :-( The way we represent eSEL ID
is wrong. Also different than hostboot, OCC. Hence it will create confusions. So
its better to fix it.

> 
> Is there a way to do this in a way that's backwards compatible?
> 

I can't think of a way to have backward compatible.


-Vasant




More information about the Skiboot mailing list