[Skiboot] [PATCH] external/gard: Fix displaying 'cleared' gard records
stewart at linux.vnet.ibm.com
Thu Jan 7 16:08:09 AEDT 2016
Cyril Bur <cyril.bur at au1.ibm.com> writes:
> When a garded component is replaced hostboot detects this and updates the
> gard partition.
> What hostboot does is set the record_id field to 0xFFFFFFFF but leaves the
> rest of the flash untouched, this has caused issues with the gard tool the
> thinking was that an entire record of all 0xFF bytes would signal not a
> valid record.
> This patch add rectifies this issue and `gard list` will no longer show any
> record with an id of 0xFFFFFFFF.
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> Stewart: Fixes BZ 131707
I gather this should also head towards stable ?
> diff --git a/external/gard/gard.c b/external/gard/gard.c
> index 0b7a68b..53f31d9 100644
> --- a/external/gard/gard.c
> +++ b/external/gard/gard.c
> @@ -41,6 +41,8 @@
> #include "gard.h"
> +#define CLEARED_RECORD_ID 0xFFFFFFFF
Prior to this patch, what was the check? We were just going until we saw
a all 0xFF gard record, right? It looks like that functionality isn't
removed, is it still correct?
OPAL Architect, IBM.
More information about the Skiboot