[Skiboot] [PATCH] hw/ipmi: fix event data 1 for System Firmware Progress sensor
Cédric Le Goater
clg at fr.ibm.com
Wed Jan 6 19:34:19 AEDT 2016
The IPMI Specs document (29.7 Event Data Field Formats) describes the
Event Data 1 field for discrete sensor as follow :
[7:6] - 00b = unspecified byte 2
01b = previous state and/or severity in byte 2
10b = OEM code in byte 2
11b = sensor-specific event extension code in byte 2
[5:4] - 00b = unspecified byte 3
01b = reserved
10b = OEM code in byte 3
11b = sensor-specific event extension code in byte 3
[3:0] - Offset from Event/Reading Code for discrete event state
The "System Firmware Progress" offset in the "System Firmware
Progress" Sensor being 0x02, we should be using 0xc2 in the event data
1 field.
Signed-off-by: Cédric Le Goater <clg at fr.ibm.com>
---
Tested on a palmetto and under qemu
hw/ipmi/ipmi-sensor.c | 1 +
1 file changed, 1 insertion(+)
Index: skiboot.git/hw/ipmi/ipmi-sensor.c
===================================================================
--- skiboot.git.orig/hw/ipmi/ipmi-sensor.c
+++ skiboot.git/hw/ipmi/ipmi-sensor.c
@@ -92,6 +92,7 @@ int ipmi_set_fw_progress_sensor(uint8_t
request.sensor_number = fw_sensor_num;
request.operation = 0xa0; /* Set event data bytes, assertion bits */
request.assertion_mask[0] = 0x04; /* Firmware progress offset */
+ request.event_data[0] = 0xc2;
request.event_data[1] = state;
prlog(PR_INFO, "IPMI: setting fw progress sensor %02x to %02x\n",
More information about the Skiboot
mailing list