[Skiboot] [PATCH] hw/bt.c: Retry sending ipmi message in bt with correct data

Vaibhav Jain vaibhav at linux.vnet.ibm.com
Tue Feb 23 16:14:37 AEDT 2016


Hi Mamatha,

A minor comment.

Mamatha Inamdar <mamatha4 at linux.vnet.ibm.com> writes:

> diff --git a/hw/bt.c b/hw/bt.c
> index df4a4f0..e4266f6 100644
> --- a/hw/bt.c
> +++ b/hw/bt.c
> @@ -397,10 +397,10 @@ static void bt_expire_old_msg(uint64_t tb)
>  			doing anything. The data will still be in the
>  			FIFO so just reset the flag.*/
>  			BT_Q_ERR(bt_msg, "Retry sending message");
> -			bt_msg->send_count++;
> -
>  			bt_msg->tb = tb;
> -			bt_outb(BT_CTRL_H2B_ATN, BT_CTRL);
> +
> +			/* retry sending ipmi_msg */
> +			bt_send_msg(bt_msg);
With this change the comment above the code isnt valid anymore. So
please update the comment accordingly.


Cheers,
~ Vaibhav



More information about the Skiboot mailing list