[Skiboot] [RFC PATCH] Enable Simics UART console
Ryan Grimm
grimm at linux.vnet.ibm.com
Thu Feb 18 03:27:35 AEDT 2016
Having a Simics console is pretty handy so I wanted to see if this was close to
upstreamable.
I stuck the console driver in lpc-uart.c so I could reuse the LPC UART code. I
had to hack up the logic in uart_con_write to continue if no lpc but if
simics_uart is present.
I'm also using a chip quirk similar to Mambo.
Is this approach OK? We could stick the driver in core/console.c like the
Mambo driver but we'd be duplicating uart code or factoring out uart code from
lpc-uart.c which seems like unnecessary effort.
Ryan Grimm (1):
Enable Simics UART console
core/chip.c | 4 ++++
core/init.c | 2 ++
hw/lpc-uart.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++---
include/chip.h | 1 +
include/console.h | 1 +
5 files changed, 68 insertions(+), 3 deletions(-)
--
1.9.1
More information about the Skiboot
mailing list