[Skiboot] [PATCH 3/5] phb3: Set CAPI mode for both CAPP units on Naples

[Philippe Bergheaud]

Michael Neuling wrote:
>>>>+		chip->capp_phb3_attached_mask = 1 << p->index;
>>>>+	} else {
>>>>+		/* Naples has two CAPP units, statically mapped.
>>>>*/
>>>>+		chip->capp_phb3_attached_mask |= 1 << p->index;
>>>
>>>
>>>
>>>Naples has 4 phbs (2 for nvdia), so do you need to check for p
>>>->index
>>>< 2 here as well and return false if so?
>>>
>>
>>I think that we do not need to check p->index here. If the phb were
>>for nvidia,
>>then phb3_set_capi_mode would return immediately after the first
>>test:
>>
>>	if (!CAPP_UCODE_LOADED(chip, p)) {
>>		PHBERR(p, "CAPP: ucode not loaded\n");
>>		return OPAL_RESOURCE;
>>	}
> 
> 
> OK.  You catch it in capp_load_ucode() here, right?
> 
> +       /* Return if PHB not attached to a CAPP unit */
> +       if ((p->rev < PHB3_REV_NAPLES_DD10) && (p->index > 2))
> +               return OPAL_HARDWARE;
> 
Precisely.

Philippe