[Skiboot] [PATCH] specfile: Fix build issues

[Cédric Le Goater]

Hello Vasant,

On 02/11/2016 06:34 AM, Vasant Hegde wrote:
> On 02/10/2016 06:30 PM, Cédric Le Goater wrote:
>> On 02/09/2016 01:44 PM, Vasant Hegde wrote:
>>> We have "%{?_smp_mflags}" in specfile. This will initiate multiple jobs.
>>> In some cases (like opal-prd), we have to first create symbolic link
>>> and then start compilation. Because of multiple jobs created by make,
>>> we hit below error.
>>>
>>> ln -sfr ../../ccan ./ccan
>>> ln -sfr ../common ./common
>>> ln -sfr ../../libflash ./libflash
>>> make: *** No rule to make target 'libflash/blocklevel.c', needed by 'libflash-blocklevel.o'.  Stop.
>>> make: *** Waiting for unfinished jobs....
>>> make: Leaving directory '/root/rpmbuild/BUILD/skiboot-skiboot-5.1.13/external/opal-prd'
>>> error: Bad exit status from /var/tmp/rpm-tmp.ZG2RS6 (%build)
>>
> 
> Cedric,
> 
>> This is bizarre. I could not reproduce with a -j16. 
>>
> 
> Hmmm. I should have elaborated little bit. I couldn't reproduce this issue on
> RHEL 7.2 .. But I am hitting this issue in fedora 23.

I was running on f23 also.
 
>> The Makefile does use a special order-only prerequisite for the links :
>>
>> 	$(OBJS): | links arch_links
> 
> This looks correct .. But we hit issue in external/opal-prd
>
>  55 $(OBJS): $(LINKS)
>
> Hence I've disable  "%{?_smp_mflags}"  for all except skiboot compilation.

What are the results if we change the Makefile ? 


Otherwise, I think it is fine to remove "%{?_smp_mflags}" like you did.


Acked-by: Cedric Le Goater <clg at fr.ibm.com>


Thanks,

C.