[Skiboot] [PATCH] specfile: Fix build issues

[Cédric Le Goater]

On 02/09/2016 01:44 PM, Vasant Hegde wrote:
> We have "%{?_smp_mflags}" in specfile. This will initiate multiple jobs.
> In some cases (like opal-prd), we have to first create symbolic link
> and then start compilation. Because of multiple jobs created by make,
> we hit below error.
> 
> ln -sfr ../../ccan ./ccan
> ln -sfr ../common ./common
> ln -sfr ../../libflash ./libflash
> make: *** No rule to make target 'libflash/blocklevel.c', needed by 'libflash-blocklevel.o'.  Stop.
> make: *** Waiting for unfinished jobs....
> make: Leaving directory '/root/rpmbuild/BUILD/skiboot-skiboot-5.1.13/external/opal-prd'
> error: Bad exit status from /var/tmp/rpm-tmp.ZG2RS6 (%build)

This is bizarre. I could not reproduce with a -j16. 

The Makefile does use a special order-only prerequisite for the links :

	$(OBJS): | links arch_links

But that looks correct. 

C.


> This patch removes "%{?_smp_mflags}" from specfile.
> 
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> CC: Cédric Le Goater <clg at fr.ibm.com>
> ---
>  skiboot.spec | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/skiboot.spec b/skiboot.spec
> index bc48695..b1bbcc6 100644
> --- a/skiboot.spec
> +++ b/skiboot.spec
> @@ -1,5 +1,5 @@
>  Name:		opal-prd
> -Version:	5.1.12
> +Version:	5.1.13
>  Release:	1%{?dist}
>  Summary:	OPAL Processor Recovery Diagnostics Daemon
> 
> @@ -50,10 +50,10 @@ services to the OS (Linux) on IBM Power and OpenPower systems.
> 
>  %build
>  SKIBOOT_VERSION=%version CROSS= make V=1 %{?_smp_mflags}
> -OPAL_PRD_VERSION=%version make %{?_smp_mflags} V=1 -C external/opal-prd
> -GARD_VERSION=%version make V=1 %{?_smp_mflags} -C external/gard
> -PFLASH_VERSION=%version make V=1 %{?_smp_mflags} -C external/pflash
> -make V=1 %{?_smp_mflags} -C external/xscom-utils
> +OPAL_PRD_VERSION=%version make V=1 -C external/opal-prd
> +GARD_VERSION=%version make V=1 -C external/gard
> +PFLASH_VERSION=%version make V=1 -C external/pflash
> +make V=1 -C external/xscom-utils
> 
>  %install
>  make -C external/opal-prd install DESTDIR=%{buildroot} prefix=/usr
> @@ -111,5 +111,8 @@ fi
>  %{_datadir}/qemu/
> 
>  %changelog
> +* Tue Feb 09 2016 Vasant Hegde <hegdevasant at linux.vnet.ibm.com> - 5.1.13
> +- Update to latest upstream release
> +
>  * Mon Nov 23 2015 Vasant Hegde <hegdevasant at linux.vnet.ibm.com> - 5.1.12
>  - initial upstream spec file
>