[Skiboot] [PATCH V8 0/9] ELOG generalization

[Mukesh Ojha]

Hi Stewart,

This patch-set really seeks your attention now.
Kindly, give your time to review this patch.

~Mukesh


On Monday 28 November 2016 03:58 PM, Mukesh Ojha wrote:
> Hi Stewart,
>
> It's been quite long since these patches are awaiting for review.
>
> I have rebased it on master.
>
> -Mukesh
>
> On Tuesday 15 November 2016 03:40 PM, Mukesh Ojha wrote:
>> Currently, in the process of committing an error from OPAL to FSP, log
>> info is first internally converted to PEL format. Then all the errors
>> reported by OPAL are logged to FSP. So, all the errors logs
>> (FSP logs + OPAL logs) FSP sends back to host via OPAL. If for some 
>> reason
>> (say FSP is down) OPAL is not able to log its error to FSP within a
>> particular time, then it sends the log to the host directly.
>>
>> This patchset improves current error log infrastructure by splitting
>> existing FSP specific error log read/write routines into common and
>> hardware(FSP) specific routines. This would make the way easier in
>> enabling the error log writing to host support for BMC and other
>> platforms.
>>
>> It involves movement of some functions from FSP specific 
>> fsp-elog-write.c
>> and fsp-elog-read.c files to core/errorlog.c . Introduction of platform
>> hooks for elog info, ack, read and resend pending logs.
>>
>> It replaces elog_init() usage with opal_elog_init().
>>
>> Mukesh Ojha (9):
>>    errorlog: Generalize the error log write path to host
>>    errorlog: Give function 'fsp_elog_write_set_head_state' a more
>>      meaningful name
>>    errorlog: Generalize the error log read path
>>    errorlog: Rename 'fsp_log_state' to 'sp_log_state'
>>    errorlog: Introduce get and put elog routine and reference count 
>> field
>>      in elog structure
>>    errorlog: Replace elog_init() with opal_elog_init() for QEMU platform
>>    errorlog: Remove the usage of 'elog_init()' routine, replaces it with
>>      'opal_elog_init()' for BMC systems
>>    errorlog: Enable error log write to host on BMC systems
>>    errorlog: Add generic elog write interface
>>
>>   core/errorlog.c             | 301 
>> +++++++++++++++++++++++++++++++++++++++++---
>>   core/init.c                 |   4 +
>>   hw/fsp/fsp-elog-read.c      |  70 +----------
>>   hw/fsp/fsp-elog-write.c     | 180 --------------------------
>>   hw/ipmi/ipmi-sel.c          |  13 ++
>>   include/errorlog.h          |  22 +++-
>>   include/fsp-elog.h          |  37 ++----
>>   include/platform.h          |  23 ++++
>>   platforms/astbmc/common.c   |   3 +-
>>   platforms/ibm-fsp/apollo.c  |   7 +-
>>   platforms/ibm-fsp/common.c  |   1 +
>>   platforms/ibm-fsp/firenze.c |   7 +-
>>   platforms/qemu/qemu.c       |   2 -
>>   13 files changed, 375 insertions(+), 295 deletions(-)
>>
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot