[Skiboot] [PATCH v2 08/14] console: add dummy_console_flush()

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Dec 20 18:46:47 AEDT 2016

On 20/12/16 18:40, Oliver O'Halloran wrote:
>> The other OPAL_CONSOLE_FLUSH call hasn't been removed yet, is having
>> competing opal_call()s a defined thing?
> No, there is always a single OPAL call handler. opal_register()
> overwrites the existing handler at runtime.

I'm referring to:

ajd at ajd:~/code/skiboot$ gg "opal_call(OPAL_CONSOLE_FLUSH"
core/console.c:opal_call(OPAL_CONSOLE_FLUSH, opal_console_flush, 1);
core/console.c:opal_call(OPAL_CONSOLE_FLUSH, dummy_console_flush, 1);

I realise opal_register() overwrites the handler at runtime, but what 
exactly happens with multiple opal_call()s?

This is of course moot as we fix it a few patches later.

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list