[Skiboot] [PATCH v2 08/14] console: add dummy_console_flush()

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Dec 20 18:33:58 AEDT 2016


On 20/12/16 17:03, Oliver O'Halloran wrote:
> Define a driver specific flush opal call in preperation for removing

preparation

> the con_ops->flush() operation.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>

Except for uncertainty below:

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

> ---
>  core/console.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/core/console.c b/core/console.c
> index be5aa6211ce4..b053e491e351 100644
> --- a/core/console.c
> +++ b/core/console.c
> @@ -373,6 +373,12 @@ static int64_t dummy_console_read(int64_t term_number, int64_t *length,
>  }
>  opal_call(OPAL_CONSOLE_READ, dummy_console_read, 3);
>
> +static int64_t dummy_console_flush(int64_t term_number __unused)
> +{
> +	return OPAL_UNSUPPORTED;
> +}
> +opal_call(OPAL_CONSOLE_FLUSH, dummy_console_flush, 1);

The other OPAL_CONSOLE_FLUSH call hasn't been removed yet, is having 
competing opal_call()s a defined thing?

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list