[Skiboot] [PATCH v2 09/14] console: add opal_con_ops API

Russell Currey ruscur at russell.cc
Tue Dec 20 18:20:08 AEDT 2016


On Tue, 2016-12-20 at 17:03 +1100, Oliver O'Halloran wrote:
> Adds a new structure that contains the implementations of the various
> OPAL console handlers. This is intended to replace the existing ad-hoc
> mechanism where the OPAL call handlers are overwritten in the OPAL
> console driver's init function.
> 
> Currently this just moves the site where the OPAL call handlers are
> overwritten to inside of console.c, but it is intended to give us a
> mechanism for implementing features such as pointer validation for the
> OPAL console calls without having to manually update each driver.
> 
> This also helps to clarify differences between the internal (skiboot)
> console and the external (OPAL) console.
> 
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---

This doesn't compile because you haven't defined dummy_opal_con yet, maybe it
needs to go after what's currently patch 10

(snowpatch caught a bisectability bug woo)


More information about the Skiboot mailing list