[Skiboot] [PATCH v2 02/12] hdat: Add processor version check for hs service ntuple

[Stewart Smith]

Oliver O'Halloran <oohall at gmail.com> writes:
> On Tue, Dec 20, 2016 at 2:34 PM, Stewart Smith
> <stewart at linux.vnet.ibm.com> wrote:
>> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>>> Host services ntuple is deprecated on P9.
>>>
>>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>>> ---
>>>  hdata/spira.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/hdata/spira.c b/hdata/spira.c
>>> index 592197e..59ffc1d 100644
>>> --- a/hdata/spira.c
>>> +++ b/hdata/spira.c
>>> @@ -1023,6 +1023,10 @@ static void hostservices_parse(void)
>>>       unsigned int size;
>>>       unsigned int ntuples_size;
>>>
>>> +     /* Deprecated on P9 */
>>> +     if (proc_gen >= proc_gen_p9)
>>> +             return;
>>> +
>>
>> I'd prefer we print an error rather than failing silently.
>
> Why? Ignoring a deprecated tuple is perfectly fine and the FSP/HB
> sometimes populate the fields anyway.

Ahhh, reality interferes - then I'm okay with no error/warning.

-- 
Stewart Smith
OPAL Architect, IBM.