[Skiboot] [PATCH v2 12/14] console: remove opal_call overwrites
Oliver O'Halloran
oohall at gmail.com
Tue Dec 20 17:03:43 AEDT 2016
These are no longer needed.
Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
---
core/console.c | 4 ----
hw/fsp/fsp-console.c | 5 -----
hw/lpc-uart.c | 8 --------
3 files changed, 17 deletions(-)
diff --git a/core/console.c b/core/console.c
index dc632151049b..f67524726486 100644
--- a/core/console.c
+++ b/core/console.c
@@ -389,7 +389,6 @@ static int64_t dummy_console_write(int64_t term_number, int64_t *length,
return OPAL_SUCCESS;
}
-opal_call(OPAL_CONSOLE_WRITE, dummy_console_write, 3);
static int64_t dummy_console_write_buffer_space(int64_t term_number,
int64_t *length)
@@ -405,7 +404,6 @@ static int64_t dummy_console_write_buffer_space(int64_t term_number,
return OPAL_SUCCESS;
}
-opal_call(OPAL_CONSOLE_WRITE_BUFFER_SPACE, dummy_console_write_buffer_space, 2);
static int64_t dummy_console_read(int64_t term_number, int64_t *length,
uint8_t *buffer)
@@ -421,13 +419,11 @@ static int64_t dummy_console_read(int64_t term_number, int64_t *length,
return OPAL_SUCCESS;
}
-opal_call(OPAL_CONSOLE_READ, dummy_console_read, 3);
static int64_t dummy_console_flush(int64_t term_number __unused)
{
return OPAL_UNSUPPORTED;
}
-opal_call(OPAL_CONSOLE_FLUSH, dummy_console_flush, 1);
static void dummy_console_poll(void *data __unused)
{
diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c
index 009ccce26641..57679d6949f2 100644
--- a/hw/fsp/fsp-console.c
+++ b/hw/fsp/fsp-console.c
@@ -783,11 +783,6 @@ void fsp_console_init(void)
if (!fsp_present())
return;
- opal_register(OPAL_CONSOLE_READ, fsp_console_read, 3);
- opal_register(OPAL_CONSOLE_WRITE_BUFFER_SPACE,
- fsp_console_write_buffer_space, 2);
- opal_register(OPAL_CONSOLE_WRITE, fsp_console_write, 3);
-
/* Wait until we got the intf query before moving on */
while (!got_intf_query)
opal_run_pollers();
diff --git a/hw/lpc-uart.c b/hw/lpc-uart.c
index 4b068b72b2e8..0800a7d8371d 100644
--- a/hw/lpc-uart.c
+++ b/hw/lpc-uart.c
@@ -450,14 +450,6 @@ void uart_setup_opal_console(void)
/* Allocate an input buffer */
in_buf = zalloc(IN_BUF_SIZE);
out_buf = zalloc(OUT_BUF_SIZE);
- prlog(PR_DEBUG, "UART: Enabled as OS console\n");
-
- /* Register OPAL APIs */
- opal_register(OPAL_CONSOLE_READ, uart_opal_read, 3);
- opal_register(OPAL_CONSOLE_WRITE_BUFFER_SPACE,
- uart_opal_write_buffer_space, 2);
- opal_register(OPAL_CONSOLE_WRITE, uart_opal_write, 3);
- opal_register(OPAL_CONSOLE_FLUSH, uart_opal_flush, 1);
opal_add_poller(uart_console_poll, NULL);
}
--
2.7.4
More information about the Skiboot
mailing list