[Skiboot] [PATCH] hw/npu: Remove obsolete config space indexes

Alistair Popple alistair at popple.id.au
Wed Dec 14 11:39:42 AEDT 2016


Thanks Gavin!

Acked-By: Alistair Popple <alistair at popple.id.au>
Reviewed-By: Alistair Popple <alistair at popple.id.au>

On Wed, 14 Dec 2016 10:00:19 AM Gavin Shan wrote:
> The PCI config space indexes NPU_DEV_CFG_{NORMAL, RDONLY, W1CR, MAX}
> are useless. This removes them.
> 
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> ---
>  include/npu.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/include/npu.h b/include/npu.h
> index 0768155..353779e 100644
> --- a/include/npu.h
> +++ b/include/npu.h
> @@ -30,15 +30,6 @@
>  #define NPU_BRICK_TL_BAR_SIZE	0x20000
>  #define NPU_BRICK_PL_BAR_SIZE	0x200000
>  
> -/* The config space of NPU device is emulated. We have different
> - * bits to represent config register properties: readonly, write-
> - * one-to-clear.
> - */
> -#define NPU_DEV_CFG_NORMAL      0
> -#define NPU_DEV_CFG_RDONLY      1
> -#define NPU_DEV_CFG_W1CLR       2
> -#define NPU_DEV_CFG_MAX         3
> -
>  /* Bytes of the emulated NPU PCI device config space. We are
>   * emulating PCI express device, not legacy one
>   */
> 



More information about the Skiboot mailing list