[Skiboot] [PATCH] include/npu.h: Remove unused struct npu_dev_trap

Alistair Popple alistair at popple.id.au
Tue Dec 13 17:26:32 AEDT 2016


Commit "0736df5 hw/npu: Use PCI virtual device" converted the npu over
to using some generic infrastructure to filter/intercept PCIe config
space writes. This made the original trap implementation redundant.
However it seems removal of the old struct definitions was missed
during the cleanup, so do that now.

Signed-off-by: Alistair Popple <alistair at popple.id.au>
---
 include/npu.h | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/include/npu.h b/include/npu.h
index 0768155..67e507e 100644
--- a/include/npu.h
+++ b/include/npu.h
@@ -75,23 +75,6 @@ struct npu_dev_cap {
 	struct list_node	link;
 };
 
-/* Config space access trap. */
-struct npu_dev_trap {
-	struct npu_dev		*dev;
-	uint32_t		start;
-	uint32_t		end;
-	void			*data;
-	int64_t			(*read)(struct npu_dev_trap *trap,
-					uint32_t offset,
-					uint32_t size,
-					uint32_t *data);
-	int64_t			(*write)(struct npu_dev_trap *trap,
-					 uint32_t offset,
-					 uint32_t size,
-					 uint32_t data);
-	struct list_node	link;
-};
-
 struct npu_dev_bar {
 	uint32_t		flags;
 	uint32_t		xscom;
-- 
2.1.4



More information about the Skiboot mailing list