[Skiboot] [PATCH] BMC/PCI: Check slot tables against detected devices
stewart at linux.vnet.ibm.com
Tue Dec 13 14:24:04 AEDT 2016
Russell Currey <ruscur at russell.cc> writes:
> On Tue, 2016-12-13 at 13:14 +1100, Stewart Smith wrote:
>> Russell Currey <ruscur at russell.cc> writes:
>> > > + case st_builtin_dev:
>> > > + if (!phb)
>> > > + break;
>> > > + phb_lock(phb);
>> > > + dev = pci_find_dev_by_location(phb, ent-
>> > > >location);
>> > > + phb_unlock(phb);
>> > Why does this require a lock?
>> It may not. By this time during boot we should be all good and no longer
>> be touching anything. An abundance of caution perhaps?
> Just curious because I couldn't see a specific reason, I think it's fine
That sounds almost like an ack :)
OPAL Architect, IBM.
More information about the Skiboot