[Skiboot] [PATCH] pci: Standardise on uint64_t pe_number

Stewart Smith stewart at linux.vnet.ibm.com
Tue Aug 30 17:21:14 AEST 2016

Russell Currey <ruscur at russell.cc> writes:
> Throughout skiboot (and the kernel) PE numbers are named "pe_no",
> "pe_num" and "pe_number", and sized as 16, 32 and 64bit uints depending
> on where you look.  This is annoying and potentially misleading in cases
> such as the OPAL API, where different calls have different int sizes
> even though the PE number they want is the same.
> Fix this by making *everything* uint64_t pe_number.  In doing this, there
> are some whitespace fixes and mve_number gets dragged into this as well
> for cases like set_msi_{32/64} where they essentially mean the same thing.
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> ---
> No functional changes.  Changing the int size in the OPAL API should make
> no difference as uints are zero extended into 64bit registers.
> I tested this and it didn't break PCI, anyway.

Thanks, merged to master as of 863ac3c5d2f8a5ea5d471167f3da5cb07aab72fc

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list