[Skiboot] [PATCH 14/34] console: Print CPU number on message lines in DEBUG builds

Stewart Smith stewart at linux.vnet.ibm.com
Mon Aug 22 15:29:27 AEST 2016

Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> This is handy to check if farming work to other CPUs is actually
> working as expected
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Breaks 'make check' as we end up including unistd.h in
run-console-log.c, which is where sync(2) is defined.

gcc -O1 -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -Werror-implicit-functi
on-declaration -Wdeclaration-after-statement -Wno-pointer-sign -Wextra -Wno-sign
-compare -Wmissing-prototypes -Wmissing-declarations -Wwrite-strings -Wcast-alig
n -Winit-self -Wframe-larger-than=1024 -Werror -DHAVE_LITTLE_ENDIAN -MMD -std=gn
u11 -Wjump-misses-init -Wsuggest-attribute=const -Wsuggest-attribute=noreturn -W
stack-usage=1024 -DDEBUG -DCCAN_LIST_DEBUG -I . -I include -O0 -g -I include -I 
. -I libfdt -o core/test/run-console-log core/test/run-console-log.c 
In file included from include/cpu.h:20:0,
                 from core/test/../console-log.c:30,
                 from core/test/run-console-log.c:34:
include/processor.h:266:20: error: static declaration of ‘sync’ follows non-stat
ic declaration
 static inline void sync(void)
In file included from core/test/../console-log.c:25:0,
                 from core/test/run-console-log.c:34:
/usr/include/unistd.h:972:13: note: previous declaration of ‘sync’ was here
 extern void sync (void) __THROW;
/home/stewart/skiboot/core/test/Makefile.check:62: recipe for target 'core/test/
run-console-log' failed

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list