[Skiboot] [PATCH V5 04/10] opal/errorlog : Removal of elog_reject_head() from 'opal_kexec_elog_notify' routine

Mukesh Ojha mukesh02 at linux.vnet.ibm.com
Sun Aug 21 18:47:22 AEST 2016

elog_reject_head() routine makes the state 'elog_read_from_fsp_head_state'
either 'ELOG_STATE_REJECTED' or 'ELOG_STATE_NONE' depending on the current
state of 'elog_read_from_fsp_head_state'.

We can remove this elog_reject_head() from 'opal_kexec_elog_notify()' as just
after that it is called inside 'fsp_opal_resend_pending_logs()'. So, it is
redundant inside opal_kexec_elog_notify() routine.

Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
Changes in V5:
 - New patch.

 hw/fsp/fsp-elog-read.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/fsp/fsp-elog-read.c b/hw/fsp/fsp-elog-read.c
index ec5316e..fb8c753 100644
--- a/hw/fsp/fsp-elog-read.c
+++ b/hw/fsp/fsp-elog-read.c
@@ -479,7 +479,6 @@ static void fsp_opal_resend_pending_logs(void)
 static bool opal_kexec_elog_notify(void *data __unused)
-	elog_reject_head();
 	elog_enabled = false;
 	opal_update_pending_evt(OPAL_EVENT_ERROR_LOG_AVAIL, 0);

More information about the Skiboot mailing list