[Skiboot] [PATCH v2 0/3] Support PCI Virtual Device

Alistair Popple alistair at popple.id.au
Thu Aug 11 15:48:57 AEST 2016


Hi Gavin,

On Thu, 11 Aug 2016 12:12:35 Gavin Shan wrote:
> The patches support PCI virtual device. The NVLinks are presented to Linux
> kernel via PCI virtual (emulated) device. As we're going to support NVLink2
> pretty soon, we need support PCI virtual device in common layer so that it
> can be shared by NVLINK1/2.
> 
> Changelog
> =========
> v1 -> v2:
>    * Rebased to master branch per requested by Stewart. No code changes
>      since v1. The last commit is f102c9d19078 ("Merge skiboot-5.3.1
>      release notes").
>    * Had quick test on Garrison1 and no obvious issues found.

When you tested did you start a CUDA application or just take a quick look at 
the config space? It would be really awesome if we could get some unit tests 
for the virtual config space as well given that this change will also impact 
existing systems...

Regards,

Alistair

> Gavin Shan (3):
>   core/pci: Improve PCI config register filter
>   core/pci: Support virtual device
>   hw/npu: Use PCI virtual device
> 
>  core/Makefile.inc      |   6 +-
>  core/pci-virt.c        | 260 ++++++++++++++++++++++++++++
>  hw/npu-hw-procedures.c |  32 ++--
>  hw/npu.c               | 450 
+++++++++++++++----------------------------------
>  hw/phb3.c              |  14 +-
>  include/npu.h          |  22 +--
>  include/pci-virt.h     |  85 ++++++++++
>  include/pci.h          |   9 +-
>  8 files changed, 518 insertions(+), 360 deletions(-)
>  create mode 100644 core/pci-virt.c
>  create mode 100644 include/pci-virt.h
> 
> 



More information about the Skiboot mailing list