[Skiboot] [PATCH] npu: reword "error" to indicate it's actually a warning
stewart at linux.vnet.ibm.com
Wed Aug 10 16:52:42 AEST 2016
Confirmed with Alistair on IRC, and earlier discussions with Russell.
Basically, I was a bit of an idiot and didn't think hard enough before
adding the FWTS annotation.
Without this patch, you get spurious FirmWare Test Suite (FWTS) warnings
about NVLink not working on machines that aren't fully populated with
Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
hw/npu.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/npu.c b/hw/npu.c
index 65db17f4806f..5247f210470b 100644
@@ -555,12 +555,7 @@ static void npu_dev_bind_pci_dev(struct npu_dev *dev)
- * @fwts-label NPUNotBound
- * @fwts-advice Start debugging why we didn't find the right device.
- * End result is that NVLink will not function properly
- prlog(PR_ERR, "%s: NPU device %04x:00:%02x.0 not binding to PCI device\n",
+ prlog(PR_INFO, "%s: No PCI device for NPU device %04x:00:%02x.0 to bind to. If you expect a GPU to be there, this is a problem.\n",
__func__, dev->npu->phb.opal_id, dev->index);
More information about the Skiboot