[Skiboot] [PATCH] hmi: Clean up NPU FIR debug messages

Russell Currey ruscur at russell.cc
Tue Aug 9 11:55:23 AEST 2016

With the skiboot log set to debug, the FIR (and related registers) were
logged all in the same message.  It was too much for one line, didn't
clarify if the numbers were in hex, and didn't show leading zeroes.

So, split it into two lines, with leading zeroes and a "0x" prefix.

Signed-off-by: Russell Currey <ruscur at russell.cc>
 core/hmi.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/core/hmi.c b/core/hmi.c
index 67a9423..69403c6 100644
--- a/core/hmi.c
+++ b/core/hmi.c
@@ -514,9 +514,10 @@ static void find_npu_checkstop_reason(int flat_chip_id,
 	if (!fatal_errors)
-	prlog(PR_DEBUG,
-	      "NPU: FIR %llx FIR mask %llx FIR ACTION0 %llx FIR ACTION1 %llx\n",
-	      npu_fir, npu_fir_mask, npu_fir_action0, npu_fir_action1);
+	prlog(PR_DEBUG, "NPU: FIR 0x%016llx mask 0x%016llx\n",
+	      npu_fir, npu_fir_mask);
+	prlog(PR_DEBUG, "NPU: ACTION0 0x%016llx, ACTION1 0x%016llx\n",
+	      npu_fir_action0, npu_fir_action1);
 	/* Set the NPU to fenced since it can't recover. */
 	npu_set_fence_state(p, true);

More information about the Skiboot mailing list