[Skiboot] [PATCH V4 5/6] Introduces get and put elog routine and reference count field in elog structure

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Aug 5 20:50:52 AEST 2016


On 07/26/2016 11:15 AM, Mukesh Ojha wrote:
> Introduces a reference count variable in the error log structure, which is
> to track the number of user of error log buffer.
>
> get_elog and put_elog routine to increment/decrement the reference count variable.
> error log buffer return to the pool on zero count of reference count.
>
> The reason of introducing this patch, as in BMC systems, we use the same
> error log buffer to send the log to both BMC, and to the host kernel. This
> patch ensures that one does not free the buffer, while the other is using it.

Probably you should explain how you are getting buffer, why it doesn't make 
sense to have separate copy for sending logs to BMC and Host, etc. That makes it 
clear why you really need refcount here.

-Vasant



More information about the Skiboot mailing list