[Skiboot] [PATCH V4 3/6] opal/errorlog : Gives function'fsp_elog_write_set_head_state' a more meaningful name

[Vasant Hegde]

On 07/26/2016 11:15 AM, Mukesh Ojha wrote:
> fsp_elog_write_set_head_state => opal_elog_write_set_head_state

Explain why "opal_elog_write_set_head_state" is more meaningful .

-Vasant

>
> Signed-off-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>
> ---
> Changes in V4:
>   - New patch.
>
>   core/errorlog.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/core/errorlog.c b/core/errorlog.c
> index d192cb6..12dc7a4 100644
> --- a/core/errorlog.c
> +++ b/core/errorlog.c
> @@ -224,7 +224,7 @@ void log_simple_error(struct opal_err_info *e_info, const char *fmt, ...)
>   }
>
>   /* This should be called with elog_write_to_host_lock lock */
> -static inline void fsp_elog_write_set_head_state(enum elog_head_state state)
> +static inline void opal_elog_write_set_head_state(enum elog_head_state state)
>   {
>   	elog_set_head_state(true, state);
>   	elog_write_to_host_head_state = state;
> @@ -248,11 +248,11 @@ bool opal_elog_info(uint64_t *opal_elog_id, uint64_t *opal_elog_size)
>   			 */
>   			prlog(PR_ERR, "%s:Inconsistent internal list state !\n",
>   					__func__);
> -			fsp_elog_write_set_head_state(ELOG_STATE_NONE);
> +			opal_elog_write_set_head_state(ELOG_STATE_NONE);
>   		} else {
>   			*opal_elog_id = head->plid;
>   			*opal_elog_size = head->log_size;
> -			fsp_elog_write_set_head_state(ELOG_STATE_FETCHED_INFO);
> +			opal_elog_write_set_head_state(ELOG_STATE_FETCHED_INFO);
>   			rc = true;
>   		}
>   	}
> @@ -273,7 +273,7 @@ static void opal_commit_elog_in_host(void)
>   		buf->log_size = create_pel_log(buf,
>   				(char *)elog_write_to_host_buffer,
>   				ELOG_WRITE_TO_HOST_BUFFER_SIZE);
> -		fsp_elog_write_set_head_state(ELOG_STATE_FETCHED_DATA);
> +		opal_elog_write_set_head_state(ELOG_STATE_FETCHED_DATA);
>   	}
>
>   	unlock(&elog_write_to_host_lock);
> @@ -290,7 +290,7 @@ bool opal_elog_read(uint64_t *buffer, uint64_t opal_elog_size,
>   		log_data = list_top(&elog_write_to_host_pending,
>   				struct errorlog, link);
>   		if (!log_data) {
> -			fsp_elog_write_set_head_state(ELOG_STATE_NONE);
> +			opal_elog_write_set_head_state(ELOG_STATE_NONE);
>   			unlock(&elog_write_to_host_lock);
>   			return rc;
>   		}
> @@ -305,7 +305,7 @@ bool opal_elog_read(uint64_t *buffer, uint64_t opal_elog_size,
>   				opal_elog_size);
>   		list_del(&log_data->link);
>   		list_add(&elog_write_to_host_processed, &log_data->link);
> -		fsp_elog_write_set_head_state(ELOG_STATE_NONE);
> +		opal_elog_write_set_head_state(ELOG_STATE_NONE);
>   		rc = true;
>   	}
>
> @@ -337,7 +337,7 @@ bool opal_elog_ack(uint64_t ack_id)
>   		log_data = list_top(&elog_write_to_host_pending,
>   				struct errorlog, link);
>   		if (ack_id == log_data->plid)
> -			fsp_elog_write_set_head_state(ELOG_STATE_NONE);
> +			opal_elog_write_set_head_state(ELOG_STATE_NONE);
>
>   		list_for_each_safe(&elog_write_to_host_pending, record,
>   				next_record, link) {
> @@ -368,7 +368,7 @@ void opal_resend_pending_logs(void)
>   		list_add_tail(&elog_write_to_host_pending, &record->link);
>   	}
>
> -	fsp_elog_write_set_head_state(ELOG_STATE_NONE);
> +	opal_elog_write_set_head_state(ELOG_STATE_NONE);
>   	unlock(&elog_write_to_host_lock);
>   	opal_commit_elog_in_host();
>   }
>