[Skiboot] [PATCH] external: remove CROSS_COMPILE from get_arch.sh
stewart at linux.vnet.ibm.com
Thu Aug 4 15:49:54 AEST 2016
Cyril Bur <cyril.bur at au1.ibm.com> writes:
> On Wed, 3 Aug 2016 13:41:19 +1000
> Oliver O'Halloran <oohall at gmail.com> wrote:
>> The intended usage of CROSS_COMPILE is to supply the common toolchain
>> prefix so that CC, LD, etc can be set automatically by make. Build systems
>> that set these variables directly don't need (or want) this behaviour so
>> using CROSS_COMPILE for any other purpose is inherently broken.
>> Currently CROSS_COMPILE is used to set CC/LD (as above), but it is also
>> used when determining the target architecture. The implementation of this
>> only requires CROSS_COMPILE set be set so get_arch.sh can use the cross
>> toolchain's the C preprocessor directly. This is unnecessary since
>> equivalent functionality can be achieved using CC in preprocessor mode
>> with the -E flag which is supported by both gcc and clang.
So... I've been watching all the various patches to all the hand-written
and hacked makefiles for our userspace bits and doing *everything* in my
power to not go off and rewrite them all to be autotools based and push
it out just before tagging skiboot 5.3.0.
The steady state for hand written makefiles for userspace is this:
broken for somebody.
So, I'm currently very much inclined to not merge any more fixes unless
they come from a packager (which pretty much means OpenBMC at this point
in time) or they're a patch to move everything over to autotools, where
at least the brain damage is well known rather than custom.
OPAL Architect, IBM.
More information about the Skiboot