[Skiboot] [PATCH v4] Allow warnings conditionally.
alastair at au1.ibm.com
Wed Apr 27 14:16:09 AEST 2016
The makefiles set CFLAGS explicitly - there was no way to append to
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819
On Wed, 2016-04-27 at 14:11 +1000, Stewart Smith wrote:
> Alastair D'Silva <alastair at d-silva.org> writes:
> > When building in CI, we want to see all potential problems noted by
> > compilers & static analysers that masquerade as a compiler, rather
> > than
> > halting on the first one.
> > This is especially important as we tend to implement
> > different/stricter/expensive checks compared to a typical compiler,
> > and
> > as such, these may not be visible when performing a normal build.
> > This patch conditionally allows compiler warnings by passing
> > ALLOW_WARNINGS=1 as a make variable. The default behavior remains
> > to
> > fault on the first warning.
> > Signed-off-by: Alastair D'Silva <alastair at d-silva.org>
> > ---
> > Changelog
> > v2: Resend without UTF8 corruption
> > v3: Rebase onto latest master
> > v4: Break long lines in description
> > ---
> > Makefile.main | 6 ++++--
> > external/gard/rules.mk | 5 ++++-
> > external/opal-prd/Makefile | 5 ++++-
> > external/shared/Makefile | 5 ++++-
> > 4 files changed, 16 insertions(+), 5 deletions(-)
> Why not just be able to append -Wno-error to CFLAGS?
More information about the Skiboot