[Skiboot] [PATCH] Allow warnings conditionally.
alastair at au1.ibm.com
Wed Apr 20 14:22:48 AEST 2016
On Wed, 2016-04-20 at 13:21 +1000, Balbir Singh wrote:
> On 20/04/16 10:34, Alastair D'Silva wrote:
> > When building in CI, we want to see all potential problems noted by
> > compilers & static analysers that masquerade as a compiler, rather
> > than
> > halting on the first one.
> Aren't such runs one-off. One would expect by induction that builds
> create warnings, if they do the build is broken and fixed right away.
> Balbir Singh
They are done automatically on every commit, using tools (and emitting
warnings) beyond what developers are currently utilising. For example,
we are currently using PMD's copy & paste detector, cppcheck & clang-
analyzer, and I expect to add more in future (where reasonable, I'll
provide integration patches so these can be run manually).
The intent here is to provide information back to the (local Ozlabs)
devs about problems that their own development environment may not have
caught, before patches are committed. To do that effectively, and to
evaluate trends/progress, we need to see all the potential problems
with a build, not just a binary compiles/doesn't compile.
Also, failing a build in CI for warnings results in the tests not being run against that commit. This is problematic in the following scenario:
- Commit 1 - Builds & passes all tests fine
- Commit 2-10 - Fails to build
- Commit 11 - Builds fine, test 13 fails
In this situation, the information about which commit breaks test 13
has been lost, and would require investigation in an environment with
those warnings permitted/disabled to track it down.
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819
More information about the Skiboot