[Skiboot] [PATCH] external/opal-prd: Ensure that struct host_interfaces matches the thunk

Jeremy Kerr jk at ozlabs.org
Mon Apr 18 14:49:26 AEST 2016


Hi Balbir,

>> Currently, we don't describe the reserved area at the end of struct
>> host_interfaces; it's in the thunk, but not the struct itself.
>>
>> This change adds the reserved area, and adds a set of runtime asserts to
>> ensure that the struct layout matches the thunk.
>>
> 
> Seems like a good idea! Should we check for deadbeef @__hinterface_end?

The 0xdeadbeef marker isn't really part of the ABI (just a hint for
debugging), so I don't think we need to enforce its presence.

Cheers,


Jeremy


More information about the Skiboot mailing list