[Skiboot] [PATCH V3 2/6] phb3: Load CAPP ucode to both CAPP units on Naples

[Philippe Bergheaud]

On 04/01/2016 04:02 AM, Stewart Smith wrote:
> Philippe Bergheaud <felix at linux.vnet.ibm.com> writes:
>
>> On 03/31/2016 06:09 AM, Stewart Smith wrote:
>>> Philippe Bergheaud <felix at linux.vnet.ibm.com> writes:
>>>> --- a/include/phb3.h
>>>> +++ b/include/phb3.h
>>>> @@ -314,6 +314,13 @@ struct phb3 {
>>>>    	struct phb		phb;
>>>>    };
>>>>
>>>> +#define PHB3_IS_NAPLES(p) ((p)->rev == PHB3_REV_NAPLES_DD10)
>>> Should this be the other way around?
>>>
>> I am not sure I understand what you mean.
>> Should I swap the operands around the operator == ?
> I replied to the wrong line, i meant this one:
>
>   +#define PHB3_MAX_CAPP_PHB_INDEX(p) (PHB3_IS_NAPLES(p) ? 1 : 2)
>
This line is correct indeed, but deserves the following comment:

/*
  * Venice/Murano have one CAPP unit, than can be attached to either 
PHB0,1 or 2.
  * Naples has two CAPP units: CAPP0 attached to PHB0, CAPP1 attached to 
PHB1.
  */

Philippe