[Skiboot] [PATCH] Rate limit OPAL_MSG_OCC to only one outstanding message to host

Patrick Williams patrick at stwcx.xyz
Fri Sep 25 14:05:44 AEST 2015


On Fri, Sep 25, 2015 at 10:59:08AM +1000, Stewart Smith wrote:
> +{
> +	lock(&occ_lock);
> +	occ_opal_msg_outstanding = false;
> +	unlock(&occ_lock);
> +}

...

> +				if (!rc) {
>  					chip->throttle = occ_data->throttle;
> +					occ_opal_msg_outstanding = true;
> +					break;

Are you sure you don't want these to be ++ / -- ?  With this current
implementation you can still run out of memory if a two or more socket
system is throwing excessive throttles from both OCCs.

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20150924/93b5f6bb/attachment.sig>


More information about the Skiboot mailing list