[Skiboot] [PATCH] external/opal-prd: move hservices_init after the ipmi and pnor init

Neelesh Gupta neelegup at linux.vnet.ibm.com
Tue Sep 8 03:26:05 AEST 2015


The IPMI device and pnor should be ready with the devices present and module
loaded before the host service interfaces. So, reorder the initialization code
in the daemon.

Suggested-by: Jeremy Kerr <jk at ozlabs.org>
Signed-off-by: Neelesh Gupta <neelegup at linux.vnet.ibm.com>
---
 external/opal-prd/opal-prd.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
index 520aef9..1e7cd23 100644
--- a/external/opal-prd/opal-prd.c
+++ b/external/opal-prd/opal-prd.c
@@ -1545,10 +1545,6 @@ static int run_prd_daemon(struct opal_prd_ctx *ctx)
 
 	fixup_hinterface_table();
 
-	pr_debug("HBRT: calling hservices_init");
-	hservices_init(ctx, ctx->code_addr);
-	pr_debug("HBRT: hservices_init done");
-
 	if (ctx->pnor.path) {
 		rc = pnor_init(&ctx->pnor);
 		if (rc) {
@@ -1559,6 +1555,10 @@ static int run_prd_daemon(struct opal_prd_ctx *ctx)
 
 	ipmi_init(ctx);
 
+	pr_debug("HBRT: calling hservices_init");
+	hservices_init(ctx, ctx->code_addr);
+	pr_debug("HBRT: hservices_init done");
+
 	/* Test a scom */
 	if (ctx->debug) {
 		uint64_t val;



More information about the Skiboot mailing list