[Skiboot] [PATCH 1/2] external/pflash: Add quiet rules and fix race

Stewart Smith stewart at linux.vnet.ibm.com
Fri Nov 27 10:08:24 AEDT 2015


Joel Stanley <joel at jms.id.au> writes:
> Adding quiet rules to make our output a bit cleaner. Building now looks
> like this:
>
> $ make
>     LN  libflash
>     LN  common
>     LN  ccan
>     CC  pflash.o
>     CC  version.o
>     LD  common-arch_flash.o
>     CC  pflash
>
> You can see the full build ouput by doing a "make V=1".
>
> By doing this, we build fractionally faster, exposing arace condition
> between running the make_version.sh script and the link existing for it.
> As we run it when creating the variable, there is no way to ensure it
> exists first.
>
> Solved this by not creating the symlink and simply running
> make_version.sh from the root.
>
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>  external/common/rules.mk | 26 ++++++++++++++++++--------
>  external/pflash/Makefile | 23 +++++++++++++++--------
>  external/pflash/rules.mk | 13 +++++++------

Series merged as of 34901e08da043bf464775292c0c292e52e217121



More information about the Skiboot mailing list