[Skiboot] [PATCH 1/4] pflash: Remove ast.h

Joel Stanley joel at jms.id.au
Thu Nov 26 14:24:14 AEDT 2015

On Thu, Nov 26, 2015 at 4:32 AM, Cédric Le Goater <clg at fr.ibm.com> wrote:

>> Note that it's hard to test that we haven't broken tools in the
>> external/ directory these days; when making changes we need to test with
>> amd64, ppc64, ppc64le and arm to ensure that everything can build!
> You could use a armel schroot. It is fast enough to compile pflash on my
> laptop.

Yeah, that's another way to do it. I've been using the Ubuntu cross compilers.

I sent in a script that sets CROSS_COMPILE for each of the
architectures in turn and builds pflash. I'll get jenkins building
this for us, which should help catch issues.

> For all patches :
>         Reviewed-by: Cédric Le Goater <clg at fr.ibm.com>
> I gave them a try on a Habanero system which has the same flash module.
> Looks good.

Thanks for the review and test!



More information about the Skiboot mailing list