[Skiboot] [PATCH 2/2] external/opal-prd: Use opal-prd as version prefix

C├ędric Le Goater clg at fr.ibm.com
Tue Nov 24 08:25:46 AEDT 2015


Jeremy,

So have we started using OPAL_PRD_VERSION in some distros ? 
If not, what would be the reason, the event, to disconnect 
from the skiboot version ? 

The skiboot place is nicely maintained and quite comfy. 

Cheers,

C.

On 07/29/2015 07:25 AM, Cyril Bur wrote:
> Cc: Jeremy Kerr <jeremy.kerr at au1.ibm.com>
> ---
>  external/opal-prd/Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/external/opal-prd/Makefile b/external/opal-prd/Makefile
> index fa5872a..db38d71 100644
> --- a/external/opal-prd/Makefile
> +++ b/external/opal-prd/Makefile
> @@ -25,7 +25,7 @@ all: opal-prd
>  
>  LINKS = ccan
>  
> -SKIBOOT_VERSION ?= $(shell ../../make_version.sh skiboot)
> +OPAL_PRD_VERSION ?= $(shell ../../make_version.sh opal-prd)
>  
>  ifdef KERNEL_DIR
>  LINKS += asm/opal-prd.h
> @@ -54,15 +54,15 @@ opal-prd: $(OBJS)
>  	$(Q_LINK)$(LINK.o) -o $@ $^
>  
>  version.c: ../../make_version.sh .version
> -	@(if [ "a$(SKIBOOT_VERSION)" = "a" ]; then \
> -	echo "#error You need to set SKIBOOT_VERSION environment variable" > $@ ;\
> +	@(if [ "a$(OPAL_PRD_VERSION)" = "a" ]; then \
> +	echo "#error You need to set OPAL_PRD_VERSION environment variable" > $@ ;\
>  	else \
> -	echo "const char version[] = \"$(SKIBOOT_VERSION)\";" ;\
> +	echo "const char version[] = \"$(OPAL_PRD_VERSION)\";" ;\
>  	fi) > $@
>  
>  .PHONY: VERSION-always
>  .version: VERSION-always
> -	@echo $(SKIBOOT_VERSION) > $@.tmp
> +	@echo $(OPAL_PRD_VERSION) > $@.tmp
>  	@cmp -s $@ $@.tmp || cp $@.tmp $@
>  	@rm -f $@.tmp
>  
> 



More information about the Skiboot mailing list