[Skiboot] [PATCH v9 04/22] core/fdt: Remove deivce_tree.h

[Daniel Axtens]

Gavin Shan <gwshan at linux.vnet.ibm.com> writes:

The subject should probably be "Remove device_tree.h"
(s/deivce/device/), but apart from that I've git grepped the definitions
and I can confirm that the header file is redundant (or just plain
wrong).

Reviewed-by: Daniel Axtens <dja at axtens.net>

Regards,
Daniel Axtens

> None of the functions declared in the header file are public. This
> removes the header file. No logical changes introduced.
>
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> ---
>  core/init.c           |  1 -
>  hdata/fsp.c           |  1 -
>  hdata/memory.c        |  1 -
>  include/device_tree.h | 35 -----------------------------------
>  4 files changed, 38 deletions(-)
>  delete mode 100644 include/device_tree.h
>
> diff --git a/core/init.c b/core/init.c
> index 6d21b55..a5cee65 100644
> --- a/core/init.c
> +++ b/core/init.c
> @@ -23,7 +23,6 @@
>  #include <cpu.h>
>  #include <processor.h>
>  #include <xscom.h>
> -#include <device_tree.h>
>  #include <opal.h>
>  #include <opal-msg.h>
>  #include <elf.h>
> diff --git a/hdata/fsp.c b/hdata/fsp.c
> index 461e6ea..90e8e5b 100644
> --- a/hdata/fsp.c
> +++ b/hdata/fsp.c
> @@ -19,7 +19,6 @@
>  #include <cpu.h>
>  #include <vpd.h>
>  #include <ccan/str/str.h>
> -#include <device_tree.h>
>  #include <interrupts.h>
>  
>  #include "hdata.h"
> diff --git a/hdata/memory.c b/hdata/memory.c
> index 01cc61b..ca21da8 100644
> --- a/hdata/memory.c
> +++ b/hdata/memory.c
> @@ -15,7 +15,6 @@
>   */
>  
>  #include <cpu.h>
> -#include <device_tree.h>
>  #include <device.h>
>  #include <vpd.h>
>  #include <ccan/str/str.h>
> diff --git a/include/device_tree.h b/include/device_tree.h
> deleted file mode 100644
> index d04f20a..0000000
> --- a/include/device_tree.h
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -/* Copyright 2013-2014 IBM Corp.
> - *
> - * Licensed under the Apache License, Version 2.0 (the "License");
> - * you may not use this file except in compliance with the License.
> - * You may obtain a copy of the License at
> - *
> - * 	http://www.apache.org/licenses/LICENSE-2.0
> - *
> - * Unless required by applicable law or agreed to in writing, software
> - * distributed under the License is distributed on an "AS IS" BASIS,
> - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> - * implied.
> - * See the License for the specific language governing permissions and
> - * limitations under the License.
> - */
> -
> -#ifndef __DEVICE_TREE_H
> -#define __DEVICE_TREE_H
> -#include <stdint.h>
> -
> -/* Note: Device tree creation has no locks. It's assumed to be done
> - * by a single processor in a non racy way
> - */
> -void *create_dtb(const struct dt_node *root);
> -
> -/* Helpers to cache errors in fdt; use this instead of fdt_* */
> -uint32_t dt_begin_node(const char *name); /* returns phandle */
> -void dt_property_string(const char *name, const char *value);
> -void dt_property_cell(const char *name, u32 cell);
> -void dt_property_cells(const char *name, int count, ...);
> -void dt_property(const char *name, const void *val, size_t size);
> -void dt_end_node(void);
> -
> -
> -#endif /* __DEVICE_TREE_H */
> -- 
> 2.1.0
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20151120/ebbfe9a9/attachment.sig>