[Skiboot] [PATCH] slw: Remove overwrites for EX_PM_CORE_ECO_VRET and EX_PM_CORE_PFET_VRET

Shreyas B Prabhu shreyas at linux.vnet.ibm.com
Mon Nov 16 14:53:41 AEDT 2015


Hi Stewart,
Can you please pick this up?



On 11/04/2015 12:41 PM, Shreyas B. Prabhu wrote:
> Remove code where we overwrite EX_PM_CORE_ECO_VRET and EX_PM_CORE_PFET_VRET
> since they are being initialized in hostboot code.
> 
> Signed-off-by: Shreyas B. Prabhu <shreyas at linux.vnet.ibm.com>
> ---
>  hw/slw.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/hw/slw.c b/hw/slw.c
> index a0090908d0ea..20aad8bfd2cb 100644
> --- a/hw/slw.c
> +++ b/hw/slw.c
> @@ -217,23 +217,6 @@ static bool slw_general_init(struct proc_chip *chip, struct cpu_thread *c)
> 
>  	prlog(PR_TRACE, "SLW: PMGP0 read   0x%016llx\n", tmp);
> 
> -
> -	/* Set CORE and ECO PFET Vret to select zero */
> -	rc = xscom_write(chip->id,
> -			 XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_CORE_PFET_VRET), 0);
> -	if (rc) {
> -		log_simple_error(&e_info(OPAL_RC_SLW_INIT),
> -			"SLW: Failed to write PM_CORE_PFET_VRET\n");
> -		return false;
> -	}
> -	rc = xscom_write(chip->id,
> -			 XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_CORE_ECO_VRET), 0);
> -	if (rc) {
> -		log_simple_error(&e_info(OPAL_RC_SLW_INIT),
> -			"SLW: Failed to write PM_CORE_ECO_VRET\n");
> -		return false;
> -	}
> -
>  	return true;
>  }
> 



More information about the Skiboot mailing list