[Skiboot] [PATCH] core/pci.c: Move device node fixups to happen after all devices are added to the DT

Alistair Popple alistair at popple.id.au
Fri Nov 13 09:47:18 AEDT 2015


It would be a good idea as nvlink may not work without this fix. That said it 
won't work anyway at the moment as we're waiting for a Hostboot update. 
Hopefully they will be pushing that out in the next week or so.

- Alistair

On Thu, 12 Nov 2015 17:12:46 Stewart Smith wrote:
> Alistair Popple <alistair at popple.id.au> writes:
> > Commit 75e9440 (PCI: Trace device node from PCI device) introduced the
> > ability for PCI devices to do fixups based on information added to the
> > device tree as part of device initialisation.
> >
> > However that patch called the fixups during device initialisation
> > meaning not all devices present in the system had been added to the
> > device tree. Depending on device initialisation order this means some
> > devices were not detected by the fixup code.
> >
> > This patch moves the calls to the fixup code until after all PCI
> > devices have been added to the device tree.
> >
> > Signed-off-by: Alistair Popple <alistair at popple.id.au>
> > ---
> >  core/pci.c | 23 +++++++++++++++++++----
> >  1 file changed, 19 insertions(+), 4 deletions(-)
> Thanks, merged as of 03c6c2d.
> Should we bump the skiboot rev we're building for garisson in op-build?

More information about the Skiboot mailing list